Docs: support for multi-language tabs #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installs the [sphinx-tabs] extension which allows creating
tabbed code snippets:
```
.. tabs::
.. code-tab:: c
int main(const int argc, const char **argv) {
return 0;
}
.. code-tab:: c++
int main(const int argc, const char **argv) {
return 0;
}
```
Added Java to the welcome page.
[sphinx-tabs]: https://github.com/djungelorm/sphinx-tabs
|
That is pretty sweet! |
rix0rrr
approved these changes
Jul 4, 2018
rix0rrr
reviewed
Jul 4, 2018
| import { App, Stack, StackProps } from '@aws-cdk/core'; | ||
| import { Topic } from '@aws-cdk/sns'; | ||
| import { Queue } from '@aws-cdk/sqs'; | ||
| .. code-tab:: js |
There was a problem hiding this comment.
The tab says JavaScript but it's TypeScript. Problem?
RomainMuller
approved these changes
Jul 4, 2018
There was a problem hiding this comment.
Love this! But I share @rix0rrr's comment on how the js tab should be a ts tab (and hopefully the syntax highlighter knows what to do?)
|
Fixed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs the sphinx-tabs extension which allows creating
tabbed code snippets:
Added Java to the welcome page: